Commitlint Plugin yields false positive for some Unicode characters

arvinxx / gitmoji-commit-workflow

😉 Gitmoji Commit Workflow

MIT License

220 stars 27 forks source link

Commitlint Plugin yields false positive for some Unicode characters #662

Closed switchnollie closed 1 year ago

switchnollie commented 1 year ago

Hello @arvinxx,

First of all amazing project. I'm using your commitlint config for a Gitlab project. On Gitlab, I can't use the codes for Gitmoji, but I use the regular Unicode Emojis (this is the standard setting for the VS Code plugin that I use anyway).

The RegEx that you used in https://github.com/arvinxx/gitmoji-commit-workflow/blob/master/packages/commitlint-plugin/src/rule.ts#L11 does not work for every Gitmoji and I get this commitlint error for a correctly formatted commit message:

Your commit should start with gitmoji code,please check the emoji code on https://gitmoji.dev/. [start-with-gitmoji]

The emoji I faced the issue was 🩹 and ✏️, I could verify it's not working with the Regex101 link (try out 🩹 chore(scope): test).

Thank you for your support!

arvinxx commented 1 year ago

It seems related with #56 #576 #493

switchnollie commented 1 year ago

This Regex101 Link evaluates your regex with all possible Gitmoji Unicodes. Only 28 of the 73 Gitmojis work with your Plugin. This makes it currently not usable.

https://regex101.com/r/shBTBg/1

arvinxx commented 1 year ago

This Regex101 Link evaluates your regex with all possible Gitmoji Unicodes. Only 28 of the 73 Gitmojis work with your Plugin. This makes it currently not usable.

https://regex101.com/r/shBTBg/1

I will try to fix it this month.