arvinxx / gitmoji-commit-workflow

😉 Gitmoji Commit Workflow
MIT License
211 stars 26 forks source link

🐛 fix(changelog): fix subCommitScope default value and reduceHeadingLevel #670

Closed canisminor1990 closed 1 year ago

canisminor1990 commented 1 year ago

The commit includes changes in the packages/changelog/.changelogrc.js, packages/changelog/src/finalizeContext/index.ts, and packages/changelog/src/templates files. It fixes the default value of subCommitScope from an empty string to null when it is not defined in customConfig.scopeDisplayName. The change ensures that commits with no scope are appropriately sorted in commitGroups.

codecov[bot] commented 1 year ago

Codecov Report

Merging #670 (20c65b5) into master (e88caf5) will increase coverage by 9.96%. The diff coverage is 90.62%.

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
+ Coverage   76.59%   86.55%   +9.96%     
==========================================
  Files          26       26              
  Lines         282      305      +23     
  Branches       73       81       +8     
==========================================
+ Hits          216      264      +48     
+ Misses         61       36      -25     
  Partials        5        5              
Impacted Files Coverage Δ
packages/changelog/src/customConfig.ts 100.00% <ø> (ø)
packages/changelog/src/handleWriterOpts.ts 96.66% <80.00%> (-3.34%) :arrow_down:
packages/changelog/src/transformer/index.ts 72.58% <85.71%> (+2.58%) :arrow_up:
packages/changelog/src/finalizeContext/index.ts 88.88% <100.00%> (+80.31%) :arrow_up:
...kages/changelog/src/transformer/typeDisplayName.ts 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

canisminor1990 commented 1 year ago

done

arvinxx commented 1 year ago

close #156

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.5.3 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.5.2 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket: