Closed sethaxen closed 1 year ago
cc @ParadaCarleton
Merging #40 (ab61f6d) into main (e011ecb) will increase coverage by
0.98%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 96.00% 96.98% +0.98%
==========================================
Files 9 9
Lines 300 299 -1
==========================================
+ Hits 288 290 +2
+ Misses 12 9 -3
Impacted Files | Coverage Δ | |
---|---|---|
src/dimensions.jl | 100.00% <100.00%> (+5.12%) |
:arrow_up: |
src/from_namedtuple.jl | 97.29% <100.00%> (+2.17%) |
:arrow_up: |
src/utils.jl | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
FYI @goedman after this PR is merged, you would need to use permute dimensions using permutedims or PermutedDimsArray in StanSample.
This PR changes the default dimension order from
(params..., draw, chain)
to(draw, chain, params...)
. While this is a breaking change, no user code that indexes and permutes dimensions using dimension names instead of indices will be impacted.This changes the ordering from that adopted in #8. The benefits are:
(sample, param)
, which is easily converted to a table of draws and which can be an input to MLJ.Downsides of this approach: