search

arviz-devs / arviz-plots

ArviZ modular plotting
https://arviz-plots.readthedocs.io
Apache License 2.0
3 stars 2 forks source link

move out new_ds to arviz-stats #102

Closed aloctavodia closed 5 days ago

aloctavodia commented 1 week ago

Depends on arviz-devs/arviz-stats#38

📚 Documentation preview 📚: https://arviz-plots--102.org.readthedocs.build/en/102/

aloctavodia commented 6 days ago

Tests are failing because with the changes in this PR the plot depends on a function that needs to be imported from arviz-stats, the function is there but not in the release version we are using for tests. Probably the easiest thing to do is just wait until a next release.

OriolAbril commented 6 days ago

We can modify the dependencies to install arviz-stats from github: https://github.com/arviz-devs/arviz-plots/blob/2758b924e5fdb620b4ac3fc645ba29e3369fc930/pyproject.toml#L30 (which we have done multiple times). Otherwise we'd have to either release constantly or end up developing very slowly

codecov-commenter commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.04%. Comparing base (60ca1bc) to head (dc5169f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #102 +/- ## ========================================== - Coverage 86.09% 86.04% -0.05% ========================================== Files 24 24 Lines 2855 2845 -10 ========================================== - Hits 2458 2448 -10 Misses 397 397 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.