search

arviz-devs / arviz-plots

ArviZ modular plotting
https://arviz-plots.readthedocs.io
Apache License 2.0
2 stars 1 forks source link

Add plot_ppc #11

Open aloctavodia opened 11 months ago

aloctavodia commented 11 months ago

Until explicit indexes are supported it won’t be possible to have the groupby like behaviour

OriolAbril commented 5 months ago

I also propose to completely get rid of the "mean" line. Nobody understands what it actually means and there are many cases where it's range is much larger than each individual sample ending up in very strange/ugly plots.

aloctavodia commented 5 months ago

Can we keep it, and make it default to False?

OriolAbril commented 5 months ago

maybe if we rename the argument and legend entry?

aloctavodia commented 5 months ago

what name(s) do you have in mind?

OriolAbril commented 5 months ago

I think we should avoid the word "mean" because it makes people think about the mean of the posterior predictive. "combined" seems to be more intuitive in plot_trace, but here we combine over samples instead of over chain only, "aggregate" might also help with avoiding relating that to the actual mean.

aloctavodia commented 5 months ago

Aggregate can be a good choice

imperorrp commented 3 months ago

Plot_ppc support for discrete values might have to be thought of as well: https://github.com/arviz-devs/arviz/issues/1103

imperorrp commented 3 months ago

Some more plot_ppc related issues with legacy Arviz plot_ppc:

A bug when zooming in: https://github.com/arviz-devs/arviz/issues/1756

A feature request for adding HDI-style credible intervals for plot_ppc: https://github.com/arviz-devs/arviz/issues/1654

OriolAbril commented 3 months ago

Plot_ppc support for discrete values might have to be thought of as well: https://github.com/arviz-devs/arviz/issues/1103

Discussion related to better support for discrete values should go to #53.