arviz-devs / arviz-plots

ArviZ modular plotting
https://arviz-plots.readthedocs.io
Apache License 2.0
2 stars 1 forks source link

[WIP] Add plot_trace_dens #27

Closed aloctavodia closed 7 months ago

aloctavodia commented 8 months ago

This is my attempt to reproduce the legacy plot_trace.

output_00

we have ecdf too!

output_01

And also a lot of mistakes.

output_03


๐Ÿ“š Documentation preview ๐Ÿ“š: https://arviz-plots--27.org.readthedocs.build/en/27/

codecov-commenter commented 7 months ago

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (e1a36c5) 76.22% compared to head (eff66bd) 65.65%.

Files Patch % Lines
src/arviz_plots/plots/tracedistplot.py 10.29% 61 Missing :warning:
src/arviz_plots/plots/utils.py 8.69% 21 Missing :warning:
src/arviz_plots/backend/matplotlib/__init__.py 25.00% 12 Missing :warning:
src/arviz_plots/visuals/__init__.py 33.33% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #27 +/- ## =========================================== - Coverage 76.22% 65.65% -10.57% =========================================== Files 10 11 +1 Lines 572 693 +121 =========================================== + Hits 436 455 +19 - Misses 136 238 +102 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

OriolAbril commented 7 months ago

Should we call this plot_trace_dist instead of plot_dens

me gusta mรกs con dist, si

aloctavodia commented 7 months ago

Merging this. We can keep working on separate PRs, I will open issues.