search

arviz-devs / arviz-plots

ArviZ modular plotting
https://arviz-plots.readthedocs.io
Apache License 2.0
2 stars 1 forks source link

PlotCollection coords attribute for better composability #39

Closed OriolAbril closed 4 months ago

OriolAbril commented 4 months ago

This PR adds a coords attribute to PlotCollection to allow better composability between plots.

With this and using the proposal in #37 (implemented for plot_dist, plot_trace and plot_trace_dist in this PR) plot_trace_dist now limits to generating the PlotCollection instance, setting default values, calling plot_trace on the right column, calling plot_dist on the left column and finally add extra labels that wouldn't match from plot_dist or plot_trace.

📚 Documentation preview 📚: https://arviz-plots--39.org.readthedocs.build/en/39/

OriolAbril commented 4 months ago

cc @imperorrp I have started adding contributing docs: https://arviz-plots--39.org.readthedocs.build/en/39/contributing/testing.html, https://arviz-plots--39.org.readthedocs.build/en/39/contributing/docs.html and https://arviz-plots--39.org.readthedocs.build/en/39/contributing/new_plot.html, hope they help

aloctavodia commented 4 months ago

This is really great!

imperorrp commented 4 months ago

cc @imperorrp I have started adding contributing docs: https://arviz-plots--39.org.readthedocs.build/en/39/contributing/testing.html, https://arviz-plots--39.org.readthedocs.build/en/39/contributing/docs.html and https://arviz-plots--39.org.readthedocs.build/en/39/contributing/new_plot.html, hope they help

Nice, thank you! Looking forward to the WIP portions when they're done