Visual Improvements for Separation Plot

arviz-devs / arviz

Exploratory analysis of Bayesian models with Python

https://python.arviz.org

Apache License 2.0

1.56k stars 388 forks source link

Visual Improvements for Separation Plot #2272

Closed arshm06 closed 9 months ago

arshm06 commented 11 months ago

Description

Visually Improved the Separation Plot. (Issue number: #2114)

Pushed the expected events marker down. Moved the legend out of the plot. Remove the axes edgeline.

Checklist

[x] Follows official PR format
[ ] Includes a sample plot to visually illustrate the changes (only for plot-related functions)
[x] New features are properly documented (with an example if appropriate)?
[ ] Includes new or updated tests to cover the new feature
[x] Code style correct (follows pylint and black guidelines)
[ ] Changes are listed in changelog

:books: Documentation preview :books:: https://arviz--2272.org.readthedocs.build/en/2272/

codecov[bot] commented 11 months ago

Codecov Report

Merging #2272 (6461dd1) into main (24c260a) will not change coverage. Report is 1 commits behind head on main. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2272   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files         122      122           
  Lines       12459    12459           
=======================================
  Hits        10952    10952           
  Misses       1507     1507

Files Changed	Coverage Δ
arviz/plots/backends/matplotlib/lmplot.py	`98.75% <100.00%> (ø)`

OriolAbril commented 10 months ago

Thanks again for the PR. There might have been an issue with the commits and/or branches. The PR looks identical to #2271, modifying plot_lm instead of plot_separation

OriolAbril commented 9 months ago

Closing for now, will reopen if updated with different changes