Update CmdstanPy converter

arviz-devs / arviz

Exploratory analysis of Bayesian models with Python

https://python.arviz.org

Apache License 2.0

1.56k stars 388 forks source link

Update CmdstanPy converter #2287

Closed ahartikainen closed 8 months ago

ahartikainen commented 8 months ago

Description

Checklist

[x] Follows official PR format
[x] Includes new or updated tests to cover the new feature
[x] Code style correct (follows pylint and black guidelines)
[x] Changes are listed in changelog

:books: Documentation preview :books:: https://arviz--2287.org.readthedocs.build/en/2287/

codecov[bot] commented 8 months ago

Codecov Report

Merging #2287 (bc153df) into main (c2d968f) will increase coverage by 0.10%. The diff coverage is 32.12%.

@@            Coverage Diff             @@
##             main    #2287      +/-   ##
==========================================
+ Coverage   86.78%   86.89%   +0.10%     
==========================================
  Files         122      122              
  Lines       12460    12628     +168     
==========================================
+ Hits        10814    10973     +159     
- Misses       1646     1655       +9

Files	Coverage Δ
arviz/data/io_cmdstanpy.py	`43.27% <32.12%> (+27.39%)`	:arrow_up:

ahartikainen commented 8 months ago

@OriolAbril this is quite minimal change and still works with older models. For test changes, we can probably create a new PR?

ahartikainen commented 8 months ago

I will quickly check cases for 1.1.0 so it will work too.

ahartikainen commented 8 months ago

So now it should support

<0.9.67 <1.0.0 <1.20 1.2.0+