search

arviz-devs / arviz

Exploratory analysis of Bayesian models with Python
https://python.arviz.org
Apache License 2.0
1.59k stars 395 forks source link

Change `numba_flag` to `False`, #2313 #2318

Closed drbenvincent closed 6 months ago

drbenvincent commented 7 months ago

2313 outlined a bug when using plot_forest. In that issue @OriolAbril proposed a fix.

This PR implements this 1 line fix.

Previously I was also running into this bug, but can confirm that the bug is fixed with this change.

📚 Documentation preview 📚: https://arviz--2318.org.readthedocs.build/en/2318/

juanitorduz commented 6 months ago

Thanks! I had been having this one as well 😅 !

OriolAbril commented 6 months ago

The bug mentioned in the issue should already be fixed in latest release, not using numba by default everywhere is a different thing which will need some more time and discussion

juanitorduz commented 6 months ago

The bug mentioned in the issue should already be fixed in latest release, not using numba by default everywhere is a different thing which will need some more time and discussion

😅 Ups! I just installed the latest release! It works now! I was assuming it was not because of this open PR! Thanks 🙏 !

drbenvincent commented 6 months ago

Closing as the issue was fixed by #2319