Open ahartikainen opened 4 years ago
I would like to work on this issue
@ahartikainen Could you please give me a very brief overview of how the implementation of user input should work?
So the output should be an InferenceData object which we pass to the plotting functions ?
I will need to show you one example. I think I have that function somewhere (inferencedata to cds)
This one ?:https://github.com/arviz-devs/arviz/pull/981 I am currently going through this
Yes, that one.
I think we could see if that could be used (or is it already used) in the bokeh plotting function.
If it is already used, we could add a possibility include cds in some dictionary/argument (probably in backend_kwargs) and if present, use it instead of CDS created in the function.
Let's think how to handle density-based plots later.
I am a little confused. I was looking at the bokeh backend file for plot_trace and I think there are already some lines of code that convert the InferenceData object to ColumnDataSource in that file itself.
Yeah, this is probably much more involved thing that it seems at first, I think I will maybe implement this.
@ahartikainen Okay
@ahartikainen Or Is there any way I could implement at least part of this? I think it would help me learn about Arviz's backend system better
Yes, we can implement this together. Let me give you instructions where we start in a few hours
Thank you! I look forward to working on this issue
Ok, I did some inspection for our plotting code, and it is certainly not ready for this feature.
I think we really need to do some serious rewriting to enable this.
I think it is better to focus on other issues for now.
cc @OriolAbril
I understand. I will continue my work on the other issues.
To enable linked brushing, we need an option for a user to input ColumnDataSource object which contains the needed data. This will also enable to combine different plot types.
We need to be explicit what different kinds of ColumnDataSources we need. At least we have
Ideally we would like to have some default fields for good hover tooltip. (Like information for draw, chain, variable name(?); dims + coords)
https://docs.bokeh.org/en/1.4.0/docs/reference/models/sources.html
https://docs.bokeh.org/en/1.4.0/docs/user_guide/data.html