Add pre-commit - Githubissues

arviz-devs / arviz_dashboard

Bayesian Dashboard built on top of Panel

Apache License 2.0

5 stars 1 forks source link

Add pre-commit #19

Closed ndmlny-qs closed 1 year ago

ndmlny-qs commented 1 year ago

Adding pre-commit to the repository. The new pre-commit directives can be found in the configuration file .pre-commit-config.yaml.
Removed excess ignore items in the .gitignore for simplicity.
Added .taplo.toml to enforce TOML file formatting.
Updated the readme for the new pre-commit hooks.
Updated the pyproject.toml file with pre-commit configuration, as well as removing the tools handled by pre-commit from the dev install directive.

Resolves #13

ndmlny-qs commented 1 year ago

Note that none of these hooks have been run on the codebase yet. That will be done in the issue #20

ndmlny-qs commented 1 year ago

thanks for the reminder, I'll update for that as well

ndmlny-qs commented 1 year ago

I left it as a flake8 error when prints are found. I think blindly removing print statements is not the greatest of dev experiences, as it removes the opportunity to convert them to a log.

We should discuss adding checks for TODO or FIXME flags that may occur as well in a future PR.

ndmlny-qs commented 1 year ago

good catch, made an issue to remove it #22