arviz-devs / preliz

A tool-box for prior elicitation.
https://preliz.readthedocs.io
Apache License 2.0
73 stars 9 forks source link

Add Distribution Gallery #465

Closed aleicazatti closed 1 month ago

aleicazatti commented 1 month ago

Description

Notes:

I didn’t know what to add as a Bayesian story or application initially. Then I thought we could mention something in the context of its use as priors. Feel free to propose changes or mention other Bayesian-focused stories, applications, explanations, or use cases.

aloctavodia commented 1 month ago

you need to add sphinx_design to requirements-docs.txt

aleicazatti commented 1 month ago

I applied the suggested changes, except the code to generate the images so we do what @OriolAbril suggests.

aloctavodia commented 1 month ago

I see math rendering issues Captura desde 2024-06-13 13-20-31

OriolAbril commented 1 month ago

I see math rendering issues

I forgot to activate dollarmath parsing, should be fixed now

OriolAbril commented 1 month ago

The main limitation I am thinking about now are the images for the grid view. Maybe the pdf one could be saved as part of the code in the notebook but not commited to the repo (docs/examples/*.png in gitignore would take care of that for example). Not sure in what order do things happen though, if the notebooks are executed as the docs are built instead of before it might not work.

EDIT: I checked the docs and executing happens before parsing, so the idea above should work. ref: https://myst-nb.readthedocs.io/en/latest/computation/execute.html

Another option would be to save the grid images independently and if needed (manually run the notebooks to save them again and update them).

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.35%. Comparing base (cd776ae) to head (c601a93). Report is 22 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #465 +/- ## ========================================== + Coverage 80.74% 82.35% +1.61% ========================================== Files 92 96 +4 Lines 7556 7896 +340 ========================================== + Hits 6101 6503 +402 + Misses 1455 1393 -62 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aloctavodia commented 1 month ago

Is this still WIP or ready to merge?

aleicazatti commented 1 month ago

Sorry for the delay. If there aren't any other suggestions, I think it is ready to merge.