issue-25: pre check range support on server

arvryna / blazer

concurrent file downloader

Apache License 2.0

16 stars 3 forks source link

issue-25: pre check range support on server #34

Closed setraj closed 3 years ago

setraj commented 3 years ago

Issue link: https://github.com/arvyshka/blazer/issues/25

Checked the "Accept-Ranges" header to check if the server supports the Range header in the request.
Created String constant for user message

arvryna commented 3 years ago

@setraj : DoesServerSupportRangeHeader check has to happen much earlier , precisely before this line cmd/blazer.go#40 because the session-id (ID combination of url and thread count) is used as the folder name of the temp file that or CLI creates for storing segments.

you might have not thought through this because the cmd/blazer.go is written very poorly (needs to be orgainzed bettter) , it is the starting point of our CLI

setraj commented 3 years ago

we should set flags.Thread = 1, before cmd/blazer.go#40 so that folder name is consistent. is that what you meant?

arvryna commented 3 years ago

we should set flags.Thread = 1, before cmd/blazer.go#40 so that folder name is consistent. is that what you meant?

yes exactly