search

arvvoid / plugin.video.hbogoeu

hGO EU, inputstream.adaptive based add-on to access HBO Go content from Kodi
https://arvvoid.github.io/plugin.video.hbogoeu/
GNU General Public License v2.0
126 stars 46 forks source link

Error with special characters in Win10 user name #146

Closed petakpa1 closed 4 years ago

petakpa1 commented 4 years ago

I run the latest version of the addon on Kodi x86 v18.4 on a W10 x64 system

The addon start, but when I want to play a movie I receive error message and the movie does not start.

Here is my Kodi log: https://paste.kodi.tv/olerululer.kodi

arvvoid commented 4 years ago

Log level changed to "LOG_LEVEL_NORMAL"

Hello, @petakpa1 you didn’t enable debug logging in Kodi, the step is mentioned and describe in instructions. Please enable debug logging and post a new log.

petakpa1 commented 4 years ago

Hi Arvvoid, Here is my full log: https://paste.kodi.tv/kegedajilo.kodi

Please note that I have a similar special characters related issue with Netflix addon prepared by CastagnaIT, but he finally succesfully solved it.

Unfortunately I am not sure whether HBOGOEU addon worked or not before I installed Netflix addon... If you need I can send you the beta version of Netflix currently used by me.

arvvoid commented 4 years ago

@petakpa1 no need this is enough to confirm the issue and see what is affected. Well special chars there where not taken into account and i didn’t test for that. Even if some os allow that is not really common and best practice. A fix is possible and not complicated but will take some time, require a fix in multiple places and testing then on both Kodi 18 and 19 (on kodi 19 things might work as they are but is in alpha so would not recomend for normal use at this time).

Will post here when a fix is ready for testing.

petakpa1 commented 4 years ago

Ok. Thank you very much for trying to solve it. If you send me beta version I can test it on my Win10 system.

From: Arv.Void Sent: Monday, April 13, 2020 10:32 PM To: arvvoid/plugin.video.hbogoeu Cc: petakpa1 ; Mention Subject: Re: [arvvoid/plugin.video.hbogoeu] Error with special characters in Win10 user name (#146)

@petakpa1 no need this is enough to confirm the issue and see what is affected. Well special chars there where not taken into account and i didn’t test for that. Even if some os allow that is not really common and best practice. A fix is possible and not complicated but will take some time, require a fix in multiple places and testing then on both Kodi 18 and 19 (on kodi 19 things might work as they are but is in alpha so would not recomend for normal use at this time).

Will post here when a fix is ready for testing.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

arvvoid commented 4 years ago

Fixed in #147

arvvoid commented 4 years ago

@all-contributors please add @petakpa1 for bug

allcontributors[bot] commented 4 years ago

@arvvoid

I've put up a pull request to add @petakpa1! :tada:

arvvoid commented 4 years ago

The issue is fixed and merged in master, will close this issue when I make a new release.

arvvoid commented 4 years ago

Fix released in https://github.com/arvvoid/plugin.video.hbogoeu/releases/tag/2.5.8 published in Kodi add-on repository