Skylink fix - Githubissues

arvvoid / plugin.video.hbogoeu

hGO EU, inputstream.adaptive based add-on to access HBO Go content from Kodi

https://arvvoid.github.io/plugin.video.hbogoeu/

GNU General Public License v2.0

126 stars 46 forks source link

Skylink fix #78

Closed arvvoid closed 4 years ago

arvvoid commented 4 years ago

Please check that your pull request pass this checks:

[x] My changes respect the Kodi add-on development rules
[x] My code is both Python 2 and 3 compatible
[x] My code follows the code style of this project
[x] I made sure there wasn't another Pull Request opened for the same update/change
[x] I have successfully tested my changes locally

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Adding a new region/hbo go version

Description:

This should fix Skylink CZ and Slovakia operator based on @ferdabasek code, the code is ready for merging after testing.

Linked to ISSUE #5

arvvoid commented 4 years ago

Please test and report results: https://github.com/arvvoid/plugin.video.hbogoeu/archive/Skylink_fix.zip

https://github.com/arvvoid/plugin.video.hbogoeu/issues/5#issuecomment-559478230

durip commented 4 years ago

everything is working lika a charm :) OSMC Kodi 18.5

ferdabasek commented 4 years ago

fix works on KODI 18.5.
on KODI 19.0. - ALPHA1 plugin cannot run

kodi.log

obrazek

arvvoid commented 4 years ago

@ferdabasek Tnx for testing. Yes on Kodi 19 Python3 Windows Build this is expected since pycryptodome is broken in that build (https://forum.kodi.tv/showthread.php?tid=348495, https://forum.kodi.tv/showthread.php?tid=348400). For Kodi 19 Python3 testing of this add-on (or any add-on having cryptodome as a dependency) until this is fixed in the Kodi 19 Windows build only MacOS or Linux builds that use the system Python3 installation is possible (is just necessary to install pycryptodomex on the system using pip). It might work on the Android Kodi 19 test build but didn't try that one so idk if its reliable for testing. A LibreElec test build with Kodi 19 Python3 exist as well I think.

But these changes should work fine on Python3.

arvvoid commented 4 years ago

I think this is ready for merging if any minor issue comes up at a later time can be easily fixed.

Since this prevents the add-on to be used by many users will speed things up merge and push a new release soon.

arvvoid commented 4 years ago

Fix included in latest release: https://github.com/arvvoid/plugin.video.hbogoeu/releases