search

arvydas / blinkstick-python

BlinkStick Python interface to control devices connected to the computer
Other
136 stars 53 forks source link

Pyhton 3 support for blinkstick-python #17

Closed robberwick closed 10 years ago

robberwick commented 11 years ago

Hopefully this should cheer you up in your current state of unwellness :-)

I realised that the current blinkstick python package was 2.7 only, and should really have had python 3 support.

this is tested with my virtualenv runing 3.2 (I'll test again with the latest 3.3), but I thought I'd turn it over to you to have a play with and kick the tyres for a while…

arvydas commented 11 years ago

Rob, you are a star! A few questions:

robberwick commented 11 years ago

Yeah, should be compatible with 2.x…

I can check with 3.1 and 3.0 as well to be on the safe side, but I don't predict any issues. On 26 Nov 2013 11:55, "Arvydas Juskevicius" notifications@github.com wrote:

Rob, you are a star! A few questions:

  • Is this still compatible with 2.x version of Python?
  • Is it enough to test with the latest version of Python 3.3 or should we also test 3.1 and 3.0? I need to know in order to set up test environments for all operating systems.

— Reply to this email directly or view it on GitHubhttps://github.com/arvydas/blinkstick-python/pull/17#issuecomment-29286488 .

arvydas commented 11 years ago

Great, I'll do some checks on OS X and Windows to be on the safe side :)

I was also wondering whether it would be worth somehow splitting the control script into a separate package to remove additional dependencies which are required only because the control script needs them, but not the actual BlinkStick module?

robberwick commented 11 years ago

I think the idea of splitting out the control script is a good one. Not sure it requires a package, though - it might be better to treat it as a download with pip install instructions.

One of the reasons being that if you're using python 3, then the websocket client package which is referenced is 2.7 only - there's a 3.x version on a branch, which I'm going to test, but unless I can identify a WS client that's compatible with 2.7/3.x, we'll be stuck with it.

On 26/11/13 15:56, Arvydas Juskevicius wrote:

Great, I'll do some checks on OS X and Windows to be on the safe side :)

I was also wondering whether it would be worth somehow splitting the control script into a separate package to remove additional dependencies which are required only because the control script needs them, but not the actual BlinkStick module?

— Reply to this email directly or view it on GitHub https://github.com/arvydas/blinkstick-python/pull/17#issuecomment-29303881.