arwelHughes / RasCAL_2019

Rascal Release version 2019
BSD 3-Clause "New" or "Revised" License
6 stars 1 forks source link

25% confidence interval shading outside of posterior peak fit #8

Closed LukeAClifton closed 1 year ago

LukeAClifton commented 2 years ago

Hey Arwel,

As requested. I've been working on moving over to RasCal2019. I've noticed some problems with the interval shading around the reflectometry data/SLD plots. In particular the shading when plotted as a 25% confidence interval is outside of the mean fit from the posterior peak values on both the SLD plots and NR vs. model plots (see image). Also the distributions compared to the experimental data seem very wide on all the results I have looked at and well outside of the experimental data in all cases except bare surfaces.

25% CI issue:

image

arwelHughes commented 2 years ago

I said Luke this is a bug and I will fix this week. Cheers, Arwel


From: LukeAClifton @.> Sent: Thursday, December 23, 2021 11:36 AM To: arwelHughes/RasCAL_2019 @.> Cc: Subscribed @.***> Subject: [arwelHughes/RasCAL_2019] 25% confidence interval shading outside of posterior peak fit (Issue #8)

Hey Arwel,

As requested. I've been working on moving over to RasCal2019. I've noticed some problems with the interval shading around the reflectometry data/SLD plots. In particular the shading when plotted as a 25% confidence interval is outside of the mean fit from the posterior peak values on both the SLD plots and NR vs. model plots (see image). Also the distributions compared to the experimental data seem very wide on all the results I have looked at and well outside of the experimental data in all cases except bare surfaces.

25% CI issue:

[image]https://user-images.githubusercontent.com/63784662/147233797-6268aed8-1214-4f7c-844f-06a962c39b2b.png

— Reply to this email directly, view it on GitHubhttps://github.com/arwelHughes/RasCAL_2019/issues/8, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGMNVXWWPV5OPV73VQHQ5Y3USMCUFANCNFSM5KUTAXDA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.***>

This email and any attachments are intended solely for the use of the named recipients. If you are not the intended recipient you must not use, disclose, copy or distribute this email or any of its attachments and should notify the sender immediately and delete this email from your system. UK Research and Innovation (UKRI) has taken every reasonable precaution to minimise risk of this email or any attachments containing viruses or malware but the recipient should carry out its own virus and malware checks before opening the attachments. UKRI does not accept any liability for any losses or damages which the recipient may sustain due to presence of any viruses.

arwelHughes commented 2 years ago

Can you send me the actual Rascal project relating to those plots plz? Ta... A


From: Hughes, Arwel (STFC,RAL,ISIS) @.> Sent: Wednesday, January 5, 2022 9:16 AM To: arwelHughes/RasCAL_2019 @.> Subject: Re: [arwelHughes/RasCAL_2019] 25% confidence interval shading outside of posterior peak fit (Issue #8)

I said Luke this is a bug and I will fix this week. Cheers, Arwel


From: LukeAClifton @.> Sent: Thursday, December 23, 2021 11:36 AM To: arwelHughes/RasCAL_2019 @.> Cc: Subscribed @.***> Subject: [arwelHughes/RasCAL_2019] 25% confidence interval shading outside of posterior peak fit (Issue #8)

Hey Arwel,

As requested. I've been working on moving over to RasCal2019. I've noticed some problems with the interval shading around the reflectometry data/SLD plots. In particular the shading when plotted as a 25% confidence interval is outside of the mean fit from the posterior peak values on both the SLD plots and NR vs. model plots (see image). Also the distributions compared to the experimental data seem very wide on all the results I have looked at and well outside of the experimental data in all cases except bare surfaces.

25% CI issue:

[image]https://user-images.githubusercontent.com/63784662/147233797-6268aed8-1214-4f7c-844f-06a962c39b2b.png

— Reply to this email directly, view it on GitHubhttps://github.com/arwelHughes/RasCAL_2019/issues/8, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGMNVXWWPV5OPV73VQHQ5Y3USMCUFANCNFSM5KUTAXDA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.***>

This email and any attachments are intended solely for the use of the named recipients. If you are not the intended recipient you must not use, disclose, copy or distribute this email or any of its attachments and should notify the sender immediately and delete this email from your system. UK Research and Innovation (UKRI) has taken every reasonable precaution to minimise risk of this email or any attachments containing viruses or malware but the recipient should carry out its own virus and malware checks before opening the attachments. UKRI does not accept any liability for any losses or damages which the recipient may sustain due to presence of any viruses.

arwelHughes commented 1 year ago

Fixed in latest release

arwelHughes commented 1 year ago

Fixed for r1.2