Fix bug with EIP191 message signing - Githubissues

arx-research / libhalo

LibHaLo - Programmatically interact with HaLo tags from the web browser, mobile application or the desktop.

https://arx.org/?source=gh

MIT License

30 stars 5 forks source link

Fix bug with EIP191 message signing #294

Closed icedevml closed 6 months ago

icedevml commented 6 months ago

Description

There is a bug in how input is passed to ethers.utils.hashMessage() when doing EIP 191 signing of the specified hex message.

Checklist

Changes to the drivers

[ ] (PR Author) The affected drivers were manually tested

Changes to CLI

[x] (PR Author) The change was manually tested with the CLI
[ ] (PR Author) The affected CLI features are working with the standalone binary (at least one platform)
[ ] (Checked by maintainer) The CLI test procedure was run by the project's maintainer

Changes to web library

[ ] (PR Author) The change was manually tested with the web library included within a classic HTML application (flat libhalo.js)
[ ] (PR Author) The change was manually tested with the web library included within an app based on frontend framework (React.js or similar based on webpack)
[ ] (Checked by maintainer) The web test suite was run by the project's maintainer

Changes to nfc-manager driver

[ ] (PR Author) The change was manually tested in React Native app
[ ] (Checked by maintainer) The test suite was run through the test React Native project