HaLo: Fix EIP-191 signing for format=hex. - Githubissues

arx-research / libhalo

LibHaLo - Programmatically interact with HaLo tags from the web browser, mobile application or the desktop.

https://arx.org/?source=gh

MIT License

35 stars 5 forks source link

HaLo: Fix EIP-191 signing for format=hex. #298

Closed icedevml closed 8 months ago

icedevml commented 8 months ago

Description

Fix a bug that caused EIP-191 hex-formatted messages to be signed incorrectly (as UTF-8 strings). Add a possibility to pass the message in hex format with 0x prefix.

Checklist

Changes to the drivers

[ ] (PR Author) The affected drivers were manually tested

Changes to CLI

[ ] (PR Author) The change was manually tested with the CLI
[ ] (PR Author) The affected CLI features are working with the standalone binary (at least one platform)
[ ] (Checked by maintainer) The CLI test procedure was run by the project's maintainer

Changes to web library

[ ] (PR Author) The change was manually tested with the web library included within a classic HTML application (flat libhalo.js)
[ ] (PR Author) The change was manually tested with the web library included within an app based on frontend framework (React.js or similar based on webpack)
[ ] (Checked by maintainer) The web test suite was run by the project's maintainer

Changes to nfc-manager driver

[ ] (PR Author) The change was manually tested in React Native app
[ ] (Checked by maintainer) The test suite was run through the test React Native project

bweick commented 8 months ago

ok this looks right to me. Think we're gonna try to do an E2E test at some point simulating the factory as well to make sure it's good but I'm getting: ethers.utils.hashMessage(ethers.utils.arrayify("0x010203"))

Which is equivalent of on-chain hashing with EIP-191 to equal out target: bcf83051a4d206c6e43d7eaa4c75429737ac0d5ee08ee68430443bd815e6ac05