arxanas / drafts.ninja

Magic: the Gathering online draft simulator; see new repository

MIT License

7 stars 10 forks source link

Open dev-id opened 8 years ago

dev-id commented 8 years ago

Adds foil overlay. Applies foil overlay to masters packs (1 per pack) and randomly inserts into all other sets (including pre-foil sets)

Potential Issues:

Brings to light this bug https://github.com/aeosynth/draft/issues/146 because of the higher occurrence of multiple of the same card in a pack
Autopick/hover overlay overrides foil background overlay
Foil card is not sorted at end of pack (rarity-wise) as it would be in a real pack

dev-id commented 8 years ago

14

arxanas commented 8 years ago

Is this PR ready to be merged?