fix: install manpages during Nix installation

arxanas / git-branchless

High-velocity, monorepo-scale workflow for Git

Apache License 2.0

3.37k stars 80 forks source link

fix: install manpages during Nix installation #1276

Open hauleth opened 3 months ago

bryango commented 3 months ago

This is no longer necessary as the man page installation has been upstreamed (by me haha), so one can simply update flake.lock and the man pages should get installed automatically.

hauleth commented 3 months ago

Yeah, but upstream fix will not fix cases, when I want to use current development tree, as for example when I want to use git branchless submit with GitHub PRs.

bryango commented 3 months ago

The flake.nix here inherits nixpkgs's packaging functions (including postInstall), but builds on top of the current git master:

https://github.com/arxanas/git-branchless/blob/3faa0744cf0b0c7c2fe2bf20e5f441776f21c6dd/flake.nix#L18-L26

So we should get the best of both worlds. I specifically did this in #1246 to achieve the goal. It should really just work. Otherwise there might be a bug...

arxanas commented 1 month ago

Is this PR still necessary given the above? I don't use Nix, so I can't tell myself.