Fixes and tests for C++20 Range compatibility - Githubissues

arximboldi / immer

Postmodern immutable and persistent data structures for C++ — value semantics at scale

https://sinusoid.es/immer

Boost Software License 1.0

2.48k stars 177 forks source link

Fixes and tests for C++20 Range compatibility #257

Closed vector-of-bool closed 1 year ago

vector-of-bool commented 1 year ago

Addresses #240, as well as finding a problem with iterator_facade not being able to model random_access_iterator.

Define tests on each container that it satisfies the intended range concept. (This will transitively validate the iterators as well)

Fix: champ_iterator() was not default_initializable, which is a required for semiregular, which is required for iterators.
Fix: iterator_facade::operator[] returned a reference_proxy, while iterator_facade::operator* returns a ReferenceT. The random_access_iterator concept requires that the operators return an identical type.

arximboldi commented 1 year ago

Thank you so much for this contribution!