arximboldi / immer

Postmodern immutable and persistent data structures for C++ — value semantics at scale
https://sinusoid.es/immer
Boost Software License 1.0
2.51k stars 185 forks source link

Use destroy_at to call explicit destructor in make_inner_n #263

Closed colugomusic closed 1 year ago

colugomusic commented 1 year ago

This fixes the MSVC madness I was experiencing before. This compiles in both C++17 and C++20 mode.

codecov-commenter commented 1 year ago

Codecov Report

Merging #263 (daff650) into master (21cc60e) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   90.50%   90.51%           
=======================================
  Files         119      119           
  Lines       12121    12122    +1     
=======================================
+ Hits        10970    10972    +2     
+ Misses       1151     1150    -1     
Impacted Files Coverage Δ
immer/detail/hamts/node.hpp 81.32% <100.00%> (+0.18%) :arrow_up: