arximboldi / immer

Postmodern immutable and persistent data structures for C++ — value semantics at scale
https://sinusoid.es/immer
Boost Software License 1.0
2.51k stars 185 forks source link

Switch away from doctest, and drop it #266

Closed pinotree closed 1 year ago

pinotree commented 1 year ago

There is only one test using doctest instead of catch2; hence, switch it to catch2, so doctest can be dropped.

This is also prompted by the fact that the old doctest copy does not build with glibc 2.34 (released 2 years ago [1]), because SIGSTKSZ is no more a constant; this was fixed long ago in doctest upstream [2][3]. Since we can get away from doctest, let's get rid of it rather than patching/updating an old copy.

[1] https://sourceware.org/pipermail/libc-alpha/2021-August/129718.html [2] https://github.com/doctest/doctest/issues/473 [3] https://github.com/doctest/doctest/commit/099d5414e97244ec44cf46b14cd176b3a3dc52e3

codecov-commenter commented 1 year ago

Codecov Report

Merging #266 (b133b77) into master (8872e23) will not change coverage. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   90.53%   90.53%           
=======================================
  Files         119      119           
  Lines       12144    12144           
=======================================
  Hits        10994    10994           
  Misses       1150     1150           
Files Changed Coverage Δ
test/experimental/dvektor.cpp 100.00% <100.00%> (ø)
arximboldi commented 1 year ago

Thank you very much!