arximboldi / immer

Postmodern immutable and persistent data structures for C++ — value semantics at scale
https://sinusoid.es/immer
Boost Software License 1.0
2.48k stars 177 forks source link

Use Catch2 as installed #267

Closed pinotree closed 1 year ago

pinotree commented 1 year ago

When building the tests, require and use Catch2 as installed in the system, rather than using an old embedded copy of it. This way, there is no risk it will stop working with newer versions of glibc/gcc/etc.

This also changes the nix packaging to disable tests & examples: they are not used in any way, so better disable them to avoid requiring bits only needed for them.

codecov-commenter commented 1 year ago

Codecov Report

Merging #267 (eec8507) into master (b70f1c2) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #267   +/-   ##
=======================================
  Coverage   90.53%   90.53%           
=======================================
  Files         119      119           
  Lines       12144    12144           
=======================================
  Hits        10994    10994           
  Misses       1150     1150           
Files Changed Coverage Δ
test/algorithm.cpp 89.01% <ø> (ø)
test/atom/generic.ipp 100.00% <ø> (ø)
test/box/generic.ipp 100.00% <ø> (ø)
test/box/recursive.cpp 94.59% <ø> (ø)
test/box/vector-of-boxes-transient.cpp 100.00% <ø> (ø)
test/detail/type_traits.cpp 100.00% <ø> (ø)
test/experimental/dvektor.cpp 100.00% <ø> (ø)
test/flex_vector/fuzzed-0.cpp 100.00% <ø> (ø)
test/flex_vector/fuzzed-1.cpp 94.44% <ø> (ø)
test/flex_vector/fuzzed-2.cpp 100.00% <ø> (ø)
... and 31 more
arximboldi commented 1 year ago

Dam, two of the jobs seem to be failing! (the last one about benchmarks can be ignored).

pinotree commented 1 year ago

The CIFuzz issue is due to the oss-fuzz configuration for immer that needs to be updated -- see https://github.com/google/oss-fuzz/pull/10759.

arximboldi commented 1 year ago

Will merge once https://github.com/google/oss-fuzz/pull/10759 is merged!

pinotree commented 1 year ago

Will merge once google/oss-fuzz#10759 is merged!

It should be good now? :)

arximboldi commented 1 year ago

It is, great!

arximboldi commented 1 year ago

Thank you so much @pinotree for taking care of updating this in all the repos!