search

arximboldi / immer

Postmodern immutable and persistent data structures for C++ — value semantics at scale
https://sinusoid.es/immer
Boost Software License 1.0
2.51k stars 185 forks source link

Mark package as arch independent #295

Open sertonix opened 1 week ago

sertonix commented 1 week ago

Otherwise the generated file will check whenever the 32/64 bit-ness matches. Since this is a header only library this check shouldn't exist.

Ref https://cmake.org/cmake/help/latest/module/CMakePackageConfigHelpers.html#generating-a-package-version-file

arximboldi commented 1 week ago

Thank you very much!

It seems there are some formatting issues in the CMake code, can you please run cmake-format, ideally in the nix-shell so it uses the same version as we do... also running the nix-shell will set up some pre-commit hooks that will prevent this issue in the future.

sertonix commented 1 week ago

cmake-format now passes but it is basically just working around the fact that cmake-format doesn't understand ARCH_INDEPENDENT: cmakelang/parse/funs/standard_modules.py#L1891

arximboldi commented 1 week ago

Thank you! Agree that it looked better before but tooling is key :)