arximboldi / lager

C++ library for value-oriented design using the unidirectional data-flow architecture — Redux for C++
https://sinusoid.es/lager/
MIT License
704 stars 66 forks source link

Use Catch2 as installed #186

Closed pinotree closed 1 year ago

pinotree commented 1 year ago

When building the tests, require and use Catch2 as installed in the system, rather than using an old embedded copy of it. This way, there is no risk it will stop working with newer versions of glibc/gcc/etc.

This also changes the nix packaging to disable tests & examples: they are not used in any way, so better disable them to avoid requiring bits only needed for them.

codecov-commenter commented 1 year ago

Codecov Report

Merging #186 (417dcf4) into master (dd29870) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files          81       81           
  Lines        2875     2875           
=======================================
  Hits         2725     2725           
  Misses        150      150           
Files Changed Coverage Δ
test/cereal/immer_array.cpp 100.00% <ø> (ø)
test/cereal/immer_box.cpp 100.00% <ø> (ø)
test/cereal/immer_flex_vector.cpp 100.00% <ø> (ø)
test/cereal/immer_vector.cpp 100.00% <ø> (ø)
test/cereal/tuple.cpp 100.00% <ø> (ø)
test/cereal/variant_with_name.cpp 100.00% <ø> (ø)
test/core.cpp 99.51% <ø> (ø)
test/cursor.cpp 99.02% <ø> (ø)
test/debug.cpp 100.00% <ø> (ø)
test/deps.cpp 100.00% <ø> (ø)
... and 20 more
pinotree commented 1 year ago

hmm the build job fails, and it seems also failed after the last push; let's see whether #187 fixes that