arximboldi / lager

C++ library for value-oriented design using the unidirectional data-flow architecture — Redux for C++
https://sinusoid.es/lager/
MIT License
704 stars 66 forks source link

Update the SDL2 CMake modules #190

Closed pinotree closed 1 year ago

pinotree commented 1 year ago
pinotree commented 1 year ago

Needs more testing -> draft for now.

codecov-commenter commented 1 year ago

Codecov Report

Merging #190 (6895601) into master (b491952) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files          81       81           
  Lines        2875     2875           
=======================================
  Hits         2725     2725           
  Misses        150      150           
arximboldi commented 1 year ago

It seems the build passed, what kind of further testing would you like to have?

pinotree commented 1 year ago

what kind of further testing would you like to have?

I was not sure yet about the approach to do for FindSDL2_ttf.cmake, since the main problem I wanted to solve was the lack of the license text (mentioned there); while the original idea was also to provide a newer/better version of it, in the end I chose to simply fix the license text, and keep the existing module (which works fine).

Hence, it should be fine to review now, thanks!

arximboldi commented 1 year ago

Thank you!!