search

arxlang / astx

https://astx.arxlang.org/
Other
1 stars 4 forks source link

docs: Add text to current example #28

Closed apkrelling closed 7 months ago

apkrelling commented 8 months ago

Pull Request description

This PR adds some text to the current example, to make it easier for the reader to understand.

This PR attempts to solve issue #25 .

Pull Request checklists

This PR is a:

About this PR:

Author's checklist:

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I confirm that the issues mentioned were fixed/resolved .
apkrelling commented 8 months ago

@xmnlab , please let me know if this helps.

xmnlab commented 8 months ago

@apkrelling , thanks for working on that. in general, it looks good, but you need to rebase your branch on top of the upstream/main. let me know if you need any help about that.

as you will see, now it would be necessary to declare the variable (VariableDeclaration) before use the variables.

review-notebook-app[bot] commented 8 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

xmnlab commented 8 months ago

@apkrelling , today was a bit crazy in my end .. sorry .. hope to have time to review that at the end of the day

apkrelling commented 7 months ago

@xmnlab , I updated this PR, rewriting the get started guide to match the style of the other tutorials, as well as adding some items you've requested. Hopefully it's better.

xmnlab commented 7 months ago

this change will be available online in the next release. thank you so much for working on that. appreciate that.

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 0.9.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: