Adding support for i128

arxlang / astx

https://astx.arxlang.org/

Other

1 stars 4 forks source link

Adding support for i128 #76

Closed vikasgrewal16 closed 4 weeks ago

vikasgrewal16 commented 1 month ago

Pull Request description

I have added support for i128 bit but not tests

xmnlab commented 1 month ago

@vikasgrewal16 thanks for working on that!

I think that it is missing just a few pieces now:

Import the new classes here: https://github.com/arxlang/astx/blob/main/src/astx/__init__.py ... following the same organization there pls
and add them to the __all__ list: https://github.com/arxlang/astx/blob/main/src/astx/__init__.py#L96, also following the same organization pls

xmnlab commented 1 month ago

thanks @vikasgrewal16 ! there is just a small issue now pointed by the linter: https://github.com/arxlang/astx/actions/runs/10442345586/job/28915168289?pr=76#step:5:38

btw, maybe you would find some useful information about contributions to open source projects here: https://opensciencelabs.org/blog/first-time-contributors/

xmnlab commented 4 weeks ago

thanks @vikasgrewal16 ! there is just a small issue now pointed by the linter: https://github.com/arxlang/astx/actions/runs/10442345586/job/28915168289?pr=76#step:5:38

btw, maybe you would find some useful information about contributions to open source projects here: https://opensciencelabs.org/blog/first-time-contributors/

@vikasgrewal16 , a friendly reminder about this comment above ... let me know if you need any help

github-actions[bot] commented 1 week ago

:tada: This PR is included in version 0.14.0 :tada:

The release is available on:

0.14.0
GitHub release

Your semantic-release bot :package::rocket: