search

aryehraber / statamic-fetch

Statamic v2 Addon — Access content directly as JSON using URL endpoints or via a simple tag.
MIT License
55 stars 8 forks source link

Added support for Taxonomies and Terms #31

Closed makkinga closed 5 years ago

makkinga commented 5 years ago

@aryehraber Nav needs to be rewritten because of the new handle routing

aryehraber commented 5 years ago

Thanks for all the work @makkinga!

One small issue, I just had a look at the diff and it looks like all spaces have been changed to tabs... Now, I don't want to start a tabs vs. spaces battle, but I'd prefer to stick with the existing spaces, mostly to be able to read a more accurate diff since now it shows all files are completely rewritten.

After that, I'm happy to merge this in!

makkinga commented 5 years ago

@aryehraber I wouldn't mind a tabs vs spaces battle 😜 I'm in team spaces though. Not realy sure why that happened. Probably because I recently reinstalled PHPStorm. I'll have it updated asap

makkinga commented 5 years ago

@aryehraber What coding standard should I use? I normally use PSR-2 but that means a lot of changes when I reformat the code. Mostly things like this:

funchtion showKittens() {
    return $this->kittens();
}

funchtion showKittens() 
{
    return $this->kittens();
}

and

if ($foo === 'bar') $foo = 'foo'

if ($foo === 'bar') {
    $foo = 'foo'
}
aryehraber commented 5 years ago

Yeah PSR-2 would be great! Most of the code should already follow it I think... If PHPStorm finds a lot of mistakes, feel free to autocorrect them. Though it's honestly not a big deal, as long as the spacing thing is fixed, I'm happy to leave it as is for now.

makkinga commented 5 years ago

Tabs should be gone

aryehraber commented 5 years ago

Awesome, thanks!

aryehraber commented 5 years ago

Released in latest version: https://github.com/aryehraber/statamic-fetch/releases/tag/v4.3

Should show up in Statamic's Marketplace shortly. Thank again @makkinga!

aryehraber commented 5 years ago

Getting reports that fetching Collections no longer works after merging this, seeing the same on my local copy. Gonna have to revert to the prev version for now.