aryella-lacerda / react-native-accessibility-engine

Make accessibility-related assertions on React Native code using React Test Renderer
MIT License
163 stars 13 forks source link

fix: add tab to list of allowed pressable roles #308

Closed heathercodes closed 1 year ago

heathercodes commented 1 year ago

Resolving one bug outlined here: https://github.com/aryella-lacerda/react-native-accessibility-engine/issues/307

adding "tabs" to the list of allowed pressable roles.

The podfile updates came when I ran yarn bootstrap

codecov[bot] commented 1 year ago

Codecov Report

Base: 99.45% // Head: 99.45% // No change to project coverage :thumbsup:

Coverage data is based on head (1123091) compared to base (43be61c). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #308 +/- ## ======================================= Coverage 99.45% 99.45% ======================================= Files 28 28 Lines 183 183 Branches 43 43 ======================================= Hits 182 182 Misses 1 1 ``` | [Impacted Files](https://codecov.io/gh/aryella-lacerda/react-native-accessibility-engine/pull/308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aryella+Lacerda) | Coverage Δ | | |---|---|---| | [src/rules/pressable-role-required/index.ts](https://codecov.io/gh/aryella-lacerda/react-native-accessibility-engine/pull/308/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aryella+Lacerda#diff-c3JjL3J1bGVzL3ByZXNzYWJsZS1yb2xlLXJlcXVpcmVkL2luZGV4LnRz) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aryella+Lacerda). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aryella+Lacerda)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

aryella-lacerda commented 1 year ago

v3.0.1 was just released with this fix ✌🏼