Closed ppfeiler closed 7 years ago
checked out @ppfeiler PR, works great!
Nice @ppfeiler !
I invite you to join the issue to discuss this! I think your actual implementation is ok, I would just encourage you to set some constants for the return values in order to stablish an API that will survive the change of these values (maybe in a future we want to change string values or we want to use integers).
This is the PR to my issue #6