arzwa / wgd

Python package and CLI for whole-genome duplication related analyses. This package is deprecated in favor of https://github.com/heche-psb/wgd.
http://wgd.readthedocs.io/en/latest/
GNU General Public License v3.0
81 stars 40 forks source link

Update Singularity (i-ADHoRe; pandas 1.2) + other fixes #73

Closed Cecilia-Sensalari closed 2 years ago

Cecilia-Sensalari commented 2 years ago

Hi Arthur, I've edited the Singularity file so to add the use of i-ADHoRe and pandas 1.2. This pull request contains more than I anticipated because I had to fix other things. Below more details!

In Singularity recipe file:

Insetup.py it is now asked to install pandas 1.2 because 0.24 was stalling the installation when using recent Python versions. On ksrates I don't have anything to report at the moment about using this version instead of 0.24, but in general it needs further checks.

In wgd_cli.py:

I hope this can come in handy and let me know if you'd like to discuss something!

Best, Cecilia

arzwa commented 2 years ago

This is great, thanks Cecilia! Since I'm sure you have tested this extensively and I don't have much time to test it, I'll just merge this in. One thing: if there is anything about the Singularity container you wish to update in the README, you're very welcome to do so, I have not worked with Singularity in ages so the info on that in the README is probably outdated.