search

as-cii / theme-flux

MIT License
2 stars 4 forks source link

Settings for which dark/light themes to use? #1

Open mturley opened 8 years ago

mturley commented 8 years ago

I love this plugin, but it would be great if I could try the solarized light/dark syntax themes without losing my theme-flux automation between them. Is that easy to add? Maybe I'll send a pull request.

as-cii commented 8 years ago

Is that easy to add?

It shouldn't be extremely difficult to add, so I can probably do so over the weekend. :sun_with_face:

PRs are very welcome, though, so in case you're interested I believe that introducing this feature should be as simple as changing the package.json file and add a configSchema section with the settings you'd like to include (in this case I'd say lightTheme, lightSyntax, darkTheme, darkSyntax). Then, replace all the occurrences of the hardcoded themes/syntaxes with calls to atom.config.get. :zap:

qwtel commented 8 years ago

I've implemented this as part of #3. I've used atom.themes.getLoadedThemes() to get a list of available themes, so the themes can be set form the settings 🙂.