as-ideas / DeepPhonemizer

Grapheme to phoneme conversion with deep learning.
MIT License
352 stars 38 forks source link

Move logging config into client code #30

Closed moritzhaller closed 1 year ago

moritzhaller commented 1 year ago

Resolves https://github.com/as-ideas/DeepPhonemizer/issues/25

cschaefer26 commented 1 year ago

Looks good, but has merge conflicts.

moritzhaller commented 1 year ago

@cschaefer26 I rebased and resolved conflicts

codecov-commenter commented 1 year ago

Codecov Report

Base: 86.61% // Head: 86.47% // Decreases project coverage by -0.15% :warning:

Coverage data is based on head (c829fba) compared to base (a06d714). Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #30 +/- ## ========================================== - Coverage 86.61% 86.47% -0.15% ========================================== Files 18 18 Lines 934 924 -10 ========================================== - Hits 809 799 -10 Misses 125 125 ``` | Flag | Coverage Δ | | |---|---|---| | tests | `86.47% <ø> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=as-ideas#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/as-ideas/DeepPhonemizer/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=as-ideas) | Coverage Δ | | |---|---|---| | [dp/utils/logging.py](https://codecov.io/gh/as-ideas/DeepPhonemizer/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=as-ideas#diff-ZHAvdXRpbHMvbG9nZ2luZy5weQ==) | `100.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=as-ideas). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=as-ideas)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

moritzhaller commented 1 year ago

@cschaefer26 I don't have write access so feel free to merge :)

cschaefer26 commented 1 year ago

Merged. I also bumped the pypi version so the fix is available for the package.