Closed cschaefer26 closed 1 year ago
@cschaefer26 I would still suggest to improve variables names by making them more explicit for better code readability (for example att -> attention, dur -> duration, sig -> ? etc)
@cschaefer26 I would still suggest to improve variables names by making them more explicit for better code readability (for example att -> attention, dur -> duration, sig -> ? etc)
Hi, could you be a bit more specific? I would not like to expand all abbreviated names as it would make the code less readable due to variable lenght (e.g. att_score_dict -> attention_score_dictionary is too long in my opinion)
@cschaefer26 I would still suggest to improve variables names by making them more explicit for better code readability (for example att -> attention, dur -> duration, sig -> ? etc)
Hi, could you be a bit more specific? I would not like to expand all abbreviated names as it would make the code less readable due to variable lenght (e.g. att_score_dict -> attention_score_dictionary is too long in my opinion)
@cschaefer26 sure, I just mentioned above the ones that I noticed in multiple variable names. For example:
with the example of att_score_dict I think attention_score_dict would be not too long but also understandable.
I understand the concern with readability of too long variables, but using too shorted and abbreviated ones reduces readability too