search

as-ideas / oil

191 stars 56 forks source link

fix: Hide iframe for screen readers and remove whitespace #187

Closed Fumler closed 6 years ago

Fumler commented 6 years ago

This PR does two things:

  1. Adds a title and aria-hidden attributes to the POI iframe.
  2. Removes whitespace from iframe by using display: block. This issue seems to not be there on the demo pages, but we experience this on our sites. Screenshots below.

In these screenshots I moved the iframe to the top of the page to illustrate better. Without display: block: image

With display: block: image

Note: I did not run tests because ChromeHeadless failed.