search

as-ideas / oil

191 stars 56 forks source link

hub.1.2.2-SNAPSHOT.min.js is searched in DocumentRoot instead of publicPath #195

Closed Ratcreamsoup closed 6 years ago

Ratcreamsoup commented 6 years ago

As I have discovered some localization bugs in release 1.2.1, I tried it with the current snapshot. I have set "publicPath": "//my.host.tld/1.2.2-SNAPSHOT/", "poi_activate_poi": true, "poi_hub_origin": "//my.host.tld", "poi_hub_path": "/1.2.2-SNAPSHOT/hub.html"

In this constellation, oil tries to fetch hub.1.2.2-SNAPSHOT.min.js from //my.host.tld/hub.1.2.2-SNAPSHOT.min.js instead of //my.host.tld//1.2.2-SNAPSHOT/hub.1.2.2-SNAPSHOT.min.js

phogel commented 6 years ago

Hi, thank you for reporting this. The contents of the file hub.1.2.2-SNAPSHOT.min.js are parsed directly into the hub.html in the release so this wrong call is only happening in the snapshot. For a quick fix how about removing the leading slash in the hub.html in line 7 to make it load the js relative to the location, i.e. src="hub.1.2.2-SNAPSHOT.min.js" ?

Ratcreamsoup commented 6 years ago

No worries, I already fixed it in my test install - I just wanted to let you know there might be a glitch in the snapshot :relaxed:

phogel commented 6 years ago

great! 👍