search

as-ideas / oil

191 stars 56 forks source link

Added features and 3rd party details #273

Open dodomorandi opened 5 years ago

dodomorandi commented 5 years ago

I added the "features" section in the advanced settings and more details for third party vendors.

The main reason behind this PR is that we are using oil on our websites, and the IAB told us we are not compliant with their specs. These changes are aimed toward a more compliant CMP.

This is the first time I contribute to oil, I am probably not aware of many guidelines so feel free to give me feedbacks.

dodomorandi commented 5 years ago

I see that many tests are failing, if you could give me some pointers about where to start, it would make my work easier.