as-ideas / oil

191 stars 56 forks source link

No close button for `.oil-nocookies` panel #281

Closed atoiv closed 3 years ago

atoiv commented 5 years ago

Current situation

When a user has disabled all cookies via their browser's settings, the user is shown a panel that informs them that they have disabled cookies from their browsers.

Currently, there is no way for the user to get rid of this panel. This is okay in large screens and designs where oil's panel is positioned on the edge of the screen.

It becomes problematic in designs where oil panel acts as a centered modal, and on smaller devices.

Current workaround

In our current implementation, we just hide the whole oil panel with global styles, when oil_no_cookies_allowed oil-event is fired. Better option would be to show the panel, and let user close it from a button.

Motivation

There is the possibility that the user has just forgotten that they have disabled cookies from their browsers settings, eg. for dev purposes, and would actually want to allow cookies to be set for advanced features of the site to work.

On the other hand, if disabling all cookies is a clear choice, the fight is sort of already lost, and there is no good reason to affect the usability of the site negatively.

Proposed functionality

Perhaps there could be a configurable option for showing the close button in the oil_no_cookies_allowed panel.