search

as-pect / visitor-as

Visitor utilities for AssemblyScript compiler transforms
Apache License 2.0
37 stars 11 forks source link

Fix package json #18

Closed yjhmelody closed 3 years ago

yjhmelody commented 3 years ago

I find the transform API behavior strange. It seems to be caused by the version change of the dependency

Property 'visit' does not exist on type 'CodecVisitor'.

yjhmelody commented 3 years ago

@willemneal ts-mixer exports types have been changed for v.5.1 -> v5.4 . But your d.ts have not updated. The lock file is not useful for lib. And If you want to lock deps such as ts-mixer, you should use =5.1.0.

willemneal commented 3 years ago

Looks good to mean just need to move asc back to a devDep and add it as a peerDep as well.

willemneal commented 3 years ago

Add back the yarn lock and it's good to go.

yjhmelody commented 3 years ago

@willemneal Hi, I find this repo is not active now. If this dependency problem is not fixed, my unit test will not work properly now.

Depending on the situation, I will folk it and maintain it by myself, and fix some known bugs and change some interface designs. Now as only supports js/ts to write transform, so this library is very important at present.

willemneal commented 3 years ago

@yjhmelody Sorry for the long delay in merging. I am in the process of cleaning up my Github notifications so that I will see all important ones.

I will make a release today for this, but for now you can use this repo as github dep in your tests.