search

asabla / AstroNvim_user

User specific settings for astrovim
0 stars 0 forks source link

Small suggestion #1

Open mehalter opened 2 years ago

mehalter commented 2 years ago

https://github.com/asabla/AstroNvim_user/blob/fbefbc41f0dd160db17073af5ba06068a3710906/init.lua#L7-L20

Hey, I am one of the AstroNvim developers and have just been looking around at what types of user repositories have been popping up around and thought I would give a comment about your default_theme setup! I noticed that you are setting the highlights for Normal group to fg and bg which is the default. By updating the colors for fg you don't need to reset that color group if you don't want to. So this can be simplified to:

 default_theme = { 
   diagnostics_style = { italic = true }, 
   -- Modify the color table 
   colors = { 
     fg = "#abb2bf", 
   },
 },

and your change to the foreground color will already be picked up !

asabla commented 2 years ago

Oh hi there! Don't know how I missed your suggestion about this (sry!). Most of my user settings are the old defaults from before that repository switch for AstroVim. Which sadly means I've had a quite a mess of old defaults and new ones.

Will certainly apply your suggested changes tho, so thanks for the feedback! :)