asacolips-projects / 13th-age

13th Age system for Foundry VTT
5 stars 2 forks source link

Showing double dice when rolling with Dice so Nice and toolkit13 #123

Closed asacolips closed 7 months ago

asacolips commented 3 years ago

In GitLab by @tbrockwood on Aug 19, 2021, 19:40

Summary

upgraded my Foundry to 0.8.9 and now whenever I roll anything from the 13th age character sheet, Dice so Nice shows the same dice on screen twice.

Ex. Choose a melee attack, it will roll 2 d20's and 2 d8's on screen, but the resulting numbers on the dice will be the same (so each D20 shows a 14, for ex) and the results shown in the chat will be appropriate. So, the numbers are rolling fine, it's just for some reason, it's showing the dice so nice roll twice every time.

I've removed all modules except Dice so Nice, and made sure all my modules and game systems are current. On my 0.7.10 setup , everything works fine.

Labels (do-not-change)

/cc @Asacolips @cswendrowski

asacolips commented 3 years ago

In GitLab by @LegoFed3 on Aug 24, 2021, 08:01

This issue stems from the introduction of a new feature in DsN 4.1.2 that automatically parses inline rolls. For now you can disable that option in DsN's settings, the next release will disable that for you and if you do decide to enable it will prevent Toolkit13's internal calls to the DsN rendering function to avoid this duplication issue.

asacolips commented 3 years ago

In GitLab by @tbrockwood on Aug 24, 2021, 08:16

Thanks, disabling that DsN feature did the trick.