Changing class or level should recalculate current HP to adapt to new max HP

[asacolips]

In GitLab by @mhilbrunner on Feb 18, 2023, 11:53

Summary

Currently, if you change the recognized class or level of a player character, maximum HP are changed, current HP are not.

Current HP should have the delta between previous and new maximum HP applied.

SRD, pg. 346:

Characters advance a level after three or four full heal-ups, i.e. between twelve and sixteen serious battles. The whole party levels up together.

Further down, for incremental advances:

Hit Points
Your maximum hit points increase as if you were one level higher. If you’re presently damaged while mid-adventure, your current hit points increase by the same amount.

Labels (do-not-change)

/cc @Asacolips @cswendrowski @LegoFed3

[asacolips]

In GitLab by @mhilbrunner on Feb 18, 2023, 18:55

Further discussion on Discord:

• It may be safe to do on every max HP change, as we believe there are no powers/abilities that modify max HP but not current HP, i.e. in combat
• Quote:

  Implementation wise the hiccup is that max hps are calculated in prepareData() which happens only way after an update() is processed. It'd be trivial to make this work (just apply the monster logic) if we move those calculations to the preUpdate() hook.