Bag of Fixes - [merged] - Githubissues

asacolips-projects / 13th-age

13th Age system for Foundry VTT

5 stars 2 forks source link

Bag of Fixes - [merged] #280

Closed asacolips closed 8 months ago

asacolips commented 1 year ago

In GitLab by @mhilbrunner on Jan 15, 2023, 23:08

Merges a-new-age -> master

Improve README formatting, especially fixing some naked links, some of which were broken/invalid
Fix two small typos in english localization
Add *.log to .gitignore (a log file is generated in the project directory on Vue build errors)
Remove New Item from Prismatic Ogre Mage SRD entry
Remove unused localization keys, most of which are from the old sheet

asacolips commented 1 year ago

In GitLab by @mhilbrunner on Jan 15, 2023, 23:13

Commented on src/languages/en.yaml line 30

I found no reference to this in code, maybe I missed something.

asacolips commented 1 year ago

In GitLab by @mhilbrunner on Jan 15, 2023, 23:13

Commented on src/languages/en.yaml line 59

Used by the old sheet.

asacolips commented 1 year ago

In GitLab by @mhilbrunner on Jan 15, 2023, 23:13

Commented on src/languages/en.yaml line 106

Found no references to these.

asacolips commented 1 year ago

In GitLab by @mhilbrunner on Jan 15, 2023, 23:13

Commented on src/languages/en.yaml line 117

Used by the old sheet.

asacolips commented 1 year ago

In GitLab by @mhilbrunner on Jan 15, 2023, 23:13

Commented on src/languages/en.yaml line 180

Used by the old sheet.

asacolips commented 1 year ago

In GitLab by @mhilbrunner on Jan 15, 2023, 23:13

Commented on src/languages/en.yaml line 198

Found no reference to this, not sure.

asacolips commented 1 year ago

In GitLab by @mhilbrunner on Jan 15, 2023, 23:13

Commented on src/languages/en.yaml line 325

No reference to this, likely replaced by the above.

asacolips commented 1 year ago

In GitLab by @mhilbrunner on Jan 15, 2023, 23:13

Commented on src/languages/en.yaml line 331

No reference to this, likely replaced by the above.

asacolips commented 1 year ago

In GitLab by @mhilbrunner on Jan 15, 2023, 23:13

Commented on src/languages/en.yaml line 336

No reference to this, likely replaced by the above.

asacolips commented 1 year ago

In GitLab by @mhilbrunner on Jan 15, 2023, 23:13

Commented on src/languages/en.yaml line 340

No reference to this, likely replaced by the above.

asacolips commented 1 year ago

In GitLab by @Asacolips on Jan 23, 2023, 19:32

Commented on src/languages/en.yaml line 30

I think it may have been replaced by using Foundry core's create i18n string. I'm good with removing it.

asacolips commented 1 year ago

In GitLab by @Asacolips on Jan 23, 2023, 19:35

Commented on src/languages/en.yaml line 106

I believe the melee and ranged strings were used on the old version of basic attacks which used to be a section of the sheet rather than separate powers. We can drop them :thumbsup:

asacolips commented 1 year ago

In GitLab by @Asacolips on Jan 23, 2023, 19:36

resolved all threads

asacolips commented 1 year ago

In GitLab by @Asacolips on Jan 23, 2023, 19:39

Commented on README.md line 10

There's an extra > on the end of this one.

asacolips commented 1 year ago

In GitLab by @mhilbrunner on Jan 24, 2023, 03:58

Commented on README.md line 10

changed this line in version 2 of the diff

asacolips commented 1 year ago

In GitLab by @mhilbrunner on Jan 24, 2023, 03:58

added 1 commit

02c1f877 - Remove 'New Item' from Prismatic Ogre Mage

Compare with previous version

asacolips commented 1 year ago

In GitLab by @mhilbrunner on Jan 24, 2023, 03:59

Commented on README.md line 10

@Asacolips Well spotted. Fixed!

asacolips commented 1 year ago

In GitLab by @LegoFed3 on Jan 24, 2023, 08:03

mentioned in commit 0b10b59b3be07225f58ba1b4239de8231cd881cf