asacolips-projects / pbta

Run games for any PbtA system in Foundry VTT!
https://asacolips.gitbook.io/pbta-system
MIT License
3 stars 7 forks source link

Add bounds options - [merged] #134

Closed asacolips closed 8 months ago

asacolips commented 1 year ago

In GitLab by @wlonk on May 8, 2023, 24:48

Merges add-bounds -> master

Some PbtA games impose bounds on total amount you can modify a roll. This adds support for including that in a game's TOML as:

If either of those are missing, this logic will be skipped, and you can modify rolls to the moon and back.

The primary example of a game that clamps rolls that I'm thinking of is Masks, which (on p32) says that, all modifiers inclusive, you can't roll at more than +4 or less than -3.

As is traditional, I offer a cute animal picture in thanks for your consideration:

Golden Retriever puppies

asacolips commented 1 year ago

In GitLab by @Asacolips on Jun 5, 2023, 12:00

@wlonk thanks for this merge request! I'll review this while I'm working on the v11 update this week and try to get it merged in if I can.

And the puppies are adorable, :100:

asacolips commented 1 year ago

In GitLab by @wlonk on Jun 5, 2023, 12:08

Cool, thanks! I tried to make it fit the interface as-designed, while not impacting extant systems negatively.

I learned years ago that open source PRs/MRs get reviewed more when you include cute animals. True facts.

asacolips commented 1 year ago

In GitLab by @wlonk on Sep 27, 2023, 18:11

I'm just checking in on this again. Have you had a chance to look over it? Thanks!

asacolips commented 1 year ago

In GitLab by @mclemente on Nov 13, 2023, 15:13

added 1 commit

Compare with previous version

asacolips commented 1 year ago

In GitLab by @mclemente on Nov 13, 2023, 15:13

mentioned in commit e9ebddd5a69155992cb2fd5f0a68deaa196377f3