Add Tag Configuration and Roll Shifting - [merged] #163

Closed asacolips closed 8 months ago

In GitLab by @mclemente on Dec 7, 2023, 15:30

Merges beta-no-data-models -> release/0.8.1

Added the Tag Configuration.
- Replaces the function of Tag items.
- Module devs can add their own tags by defining game.pbta.tagConfigOverride.
Added Roll Shifting (Closes #76).
- Sheet Configuration rollShifting = true
Added a Hide Sidebar buttons setting.
Changed List's multi-checkbox to accept spaces in-between the label (e.g. Condition | 3).
Removed the ability to create Tag items and added a warning on Tag item sheets.
Removed the "Welcome to the Alpha" header from the Sheet Configuration and update the notes.

Bugfixes

Fixed Speaker and RollMode not being set on rolls.
Fixed Forward/Ongoing making rolls fail if no condition is set.
Fixed NPC Move Rolls not showing Result Ranges.
Fixed Stat Toggle only setting toggled stats' values to 0.

Codebase

Added eslint and JSDoc.
Moved dependencies to devDependencies.

In GitLab by @mclemente on Dec 7, 2023, 16:19

added 1 commit

48eafa05 - Fix hiding Roll Shift buttons

Compare with previous version

In GitLab by @mclemente on Dec 7, 2023, 16:30

added 1 commit

46e158d3 - Fix statToggle rolls

Compare with previous version

In GitLab by @mclemente on Dec 7, 2023, 16:42

added 1 commit

ea983ff0 - Improve multi-select List's regex

Compare with previous version

In GitLab by @mclemente on Dec 8, 2023, 10:14

added 1 commit

5c332bfc - Update rolls.js

Compare with previous version

In GitLab by @mclemente on Dec 8, 2023, 10:15

added 1 commit

8413cba4 - Update rolls.js

Compare with previous version

In GitLab by @mclemente on Dec 8, 2023, 15:47

added 1 commit

f85a0d68 - Add Speaker and RollMode to rolls

Compare with previous version

In GitLab by @mclemente on Dec 9, 2023, 11:58

added 1 commit

fa5485d6 - Remove commented out html

Compare with previous version

In GitLab by @Asacolips on Dec 10, 2023, 12:15

Commented on src/templates/dialog/sheet-config.html line 7

These were intentionally set up as two separate paragraphs both for legibility and for semantics. Let's restore that and remove the <br /> tag.

In GitLab by @mclemente on Dec 10, 2023, 12:31

Commented on src/templates/dialog/sheet-config.html line 7

changed this line in version 9 of the diff

In GitLab by @mclemente on Dec 10, 2023, 12:31

added 1 commit

9f359bc5 - Update sheet-config.html

Compare with previous version

In GitLab by @mclemente on Dec 10, 2023, 12:31

resolved all threads

In GitLab by @Asacolips on Dec 10, 2023, 12:34

Commented on src/styles/src/global/components/_tag-config.scss line 11

To help separate the categories a bit more.

    .tags {
      margin-bottom: 12px;
    }

    .tag-category {
      + .tag-category {
        border-top: 1px solid #ccc;
      }

Additionally, I would add something like this to _tags.scss to correct the issues with the input being misaligned compared to the tags.

.tagify {
  .tagify__tag,
  .tagify__input {
    height: 24px;
    padding: var(--tag-pad);
  }
}

In GitLab by @mclemente on Dec 10, 2023, 12:49

resolved all threads

In GitLab by @mclemente on Dec 10, 2023, 12:49

added 1 commit

f35aa57e - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

In GitLab by @mclemente on Dec 10, 2023, 12:49

added 1 commit

e439f5b2 - Update _tags.scss

Compare with previous version

In GitLab by @mclemente on Dec 10, 2023, 12:54

Commented on src/styles/src/global/components/_tag-config.scss line 11

I don't think the input needs the extra padding, applying it misaligns inputs

With padding:

Animação11

Without padding:

Animação12

The height is good, though.

In GitLab by @mclemente on Dec 10, 2023, 12:56

added 1 commit

7fe69843 - Update _tags.scss

Compare with previous version

In GitLab by @mclemente on Dec 10, 2023, 12:59

Just pushed a change to remove a warning from Tagify when trying to load an invalid input (specifically the general module tag category if none was present).

In GitLab by @mclemente on Dec 10, 2023, 13:00

added 1 commit