asacristani / fastapi-rocket-boilerplate

🐍💨 FastAPI Rocket Boilerplate to build an API based in Python with its most modern technologies!
MIT License
464 stars 65 forks source link

Quality code: Resolve all the issues showed by trunk check #34

Open asacristani opened 7 months ago

asacristani commented 7 months ago

If you run trunk check -a, there are several issues to resolve.

abdur-n-tr commented 6 months ago

@asacristani I want to take on this issue but first I want to ask a couple of questions before proceeding so I can follow the standards that other contributors are following,

Please guide me if we are following a different workflow here.

Also, I setup the project locally and ran trunk check -a and it highlighted a couple of issues in different categories as attached in the snapshot. Do you recommend fixing all of them in one go and submit PR or should I break them like one PR for "unformatted issues" and similarly for other issue types?

issue1

asacristani commented 6 months ago

@abdurrehman11 you are right. Thanks so much for resolving this. I cannot wait for see your solution.